This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] IPA ICF: make algorithm stable to survive -fcompare-debug


Hi Martin,

On 10 January 2017 at 15:40, Martin Liška <mliska@suse.cz> wrote:
> On 01/10/2017 02:56 PM, Richard Biener wrote:
>>
>> On Mon, Jan 9, 2017 at 4:05 PM, Martin Liška <mliska@suse.cz> wrote:
>>>
>>> Second part of the patch does sorting of final congruence classes, it's
>>> groups
>>> and items included in the groups according DECL_UID.
>>>
>>> Both patches can bootstrap together on ppc64le-redhat-linux and survive
>>> regression tests.
>>>
>>> Ready to be installed?
>>
>>
>> Minor nit:
>>
>> +  auto_vec <congruence_class_group *> classes;
>> +  for (hash_table<congruence_class_hash>::iterator it = m_classes.begin
>> ();
>> +       it != m_classes.end (); ++it)
>> +    classes.safe_push (*it);
>>
>> use quick_push and reserve_exact m_classes.elements () elements for
>> the classes vector before.
>
>
> Thanks for hint.
>
>>
>> +
>> +  classes.qsort (sort_congruence_class_groups_by_decl_uid);
>>
>> Ok with that change.
>
>
> Installed as r244273.
>
Since then, I've noticed that
  gcc.dg/tree-ssa/flatten-3.c scan-assembler cycle[123][: \t\n]
now fails on aarch64 and arm targets.

Christophe



> Martin
>
>>
>> Richard.
>>
>>
>>> Martin
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]