This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] Introduce RTL function reader


On 01/06/2017 09:43 AM, David Malcolm wrote:
On Fri, 2017-01-06 at 17:25 +0100, Jakub Jelinek wrote:
On Thu, Jan 05, 2017 at 03:20:26PM -0500, David Malcolm wrote:
+  /* Handle "reuse_rtx".  */
+  if (strcmp (code_name, "reuse_rtx") == 0)
+    {
+      read_name (&name);
+      long idx = atoi (name.string);
+      /* Look it up by ID.  */
+      gcc_assert (idx < m_reuse_rtx_by_id.length ());
+      return_rtx = m_reuse_rtx_by_id[idx];
+      return return_rtx;
+    }

This broke bootstrap on i686-linux (and other ILP32 hosts), because
vec.h length () returns unsigned.

Sorry about the breakage.

I'm not able to approve the patch, but the fix looks to me like it
would be covered under the "obvious" rule.
Can't the code string be "-1" for an insn that hasn't passed through recog yet? You can probably get those in a dump at various times.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]