Re: [PATCH 2/6][ARM] Move CRC builtins to refactored framework

["Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>]

On 05/01/17 10:27, Kyrill Tkachov wrote:
> 
> On 05/12/16 15:05, Andre Vieira (lists) wrote:
>> On 01/12/16 17:25, Andre Vieira (lists) wrote:
>>> On 09/11/16 10:11, Andre Vieira (lists) wrote:
>>>> Hi,
>>>>
>>>> This patch refactors the implementation of the ARM ACLE CRC builtins to
>>>> use the builtin framework.
>>>>
>>>> Is this OK for trunk?
>>>>
>>>> Regards,
>>>> Andre
>>>>
>>>> gcc/ChangeLog
>>>> 2016-11-09  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>>
>>>>    * config/arm/arm-builtins.c (arm_unsigned_binop_qualifiers): New.
>>>>    (UBINOP_QUALIFIERS): New.
>>>>    (si_UP): Define.
>>>>    (acle_builtin_data): New. Change comment.
>>>>    (arm_builtins): Remove ARM_BUILTIN_CRC32B, ARM_BUILTIN_CRC32H,
>>>>    ARM_BUILTIN_CRC32W, ARM_BUILTIN_CRC32CB, ARM_BUILTIN_CRC32CH,
>>>>    ARM_BUILTIN_CRC32CW. Add ARM_BUILTIN_ACLE_BASE and include
>>>>    arm_acle_builtins.def.
>>>>    (ARM_BUILTIN_ACLE_PATTERN_START): Define.
>>>>    (arm_init_acle_builtins): New.
>>>>    (CRC32_BUILTIN): Remove.
>>>>    (bdesc_2arg): Remove entries for crc32b, crc32h, crc32w,
>>>>    crc32cb, crc32ch and crc32cw.
>>>>    (arm_init_crc32_builtins): Remove.
>>>>    (arm_init_builtins): Use arm_init_acle_builtins rather
>>>>    than arm_init_crc32_builtins.
>>>>    (arm_expand_acle_builtin): New.
>>>>    (arm_expand_builtin): Use 'arm_expand_acle_builtin'.
>>>>    * config/arm/arm_acle_builtins.def: New.
>>>>
>>> Hi,
>>>
>>> Reworked this patch based on the changes made in [1/6]. No changes to
>>> ChangeLog.
>>>
>>> Is this OK?
> 
> Ok assuming normal bootstrap and regtest on an arm-none-linux-gnueabihf
> target.
> Thanks,
> Kyrill
> 
>>> Cheers,
>>> Andre
>>>
>> Hi,
>>
>> I had a typo in one of the range checks was using ARM_BUILTIN_ACLE_MAX
>> where it should've been ARM_BUILTIN_ACLE_BASE.
>>
>> Cheers,
>> Andre
> 
Hi,

I rebased the series, the first patch only had whitespace changes, this
one has a context change, so I thought I'd send it upstream in case you
want to apply them locally.

Cheers,
Andre

Attachment: diff2
Description: Text document