This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2,rs6000] PR78056: Finish fixing build failure on Power7
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Kelvin Nilsen <kdnilsen at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 22 Dec 2016 13:09:04 -0600
- Subject: Re: [PATCH v2,rs6000] PR78056: Finish fixing build failure on Power7
- Authentication-results: sourceware.org; auth=none
- References: <7b911e8f-1852-a229-7faa-c179b7ef4db4@linux.vnet.ibm.com>
Hi Kelvin,
On Fri, Dec 16, 2016 at 04:57:12PM -0700, Kelvin Nilsen wrote:
> 2016-12-16 Kelvin Nilsen <kelvin@gcc.gnu.org>
>
> PR target/78056
> * gcc.target/powerpc/pr78056-1.c: New test.
> * gcc.target/powerpc/pr78056-2.c: New test.
> * gcc.target/powerpc/pr78056-3.c: New test.
> * gcc.target/powerpc/pr78056-4.c: New test.
> * gcc.target/powerpc/pr78056-5.c: New test.
> * gcc.target/powerpc/pr78056-6.c: New test.
> * gcc.target/powerpc/pr78056-7.c: New test.
> * gcc.target/powerpc/pr78056-8.c: New test.
> * lib/target-supports.exp
> (check_effective_target_powerpc_popcntb_ok): New procedure to test
> whether the effective target supports the popcntb instruction.
>
> gcc/ChangeLog:
>
> 2016-12-16 Kelvin Nilsen <kelvin@gcc.gnu.org>
>
> PR target/78056
> * doc/sourcebuild.texi (PowerPC-specific attributes): Add
> documentation of the powerpc_popcntb_ok attribute.
> * config/rs6000/rs6000.c (rs6000_option_override_internal): Add
> code to issue warning messages if a requested CPU configuration is
> not supported by the binary (assembler and loader) toolchain.
> (spe_init_builtins): Add two assertions to prevent ICE if attempt is
> made to define a built-in function that has been disabled.
> (paired_init_builtins): Add assertion to prevent ICE if attempt is
> made to define a built-in function that has been disabled.
> (altivec_init_builtins): Add comment explaining why definition
> of the DST built-in functions is not preceded by an assertion
> check. Add assertions to prevent ICE if attempts are made to
> define an altivec predicate or an abs* built-in function that has
> been disabled.
> (htm_init_builtins): Add comment explaining why definition of the
> htm built-in functions is not preceded by an assertion check.
Approved for trunk, please apply. I don't think things are perfect yet,
but this is a step forward :-)
Segher