This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR78879

From: Jeff Law <law at redhat dot com>
To: "Yuan, Pengfei" <ypf at pku dot edu dot cn>, gcc-patches at gcc dot gnu dot org
Cc: trippels at gcc dot gnu dot org
Date: Thu, 22 Dec 2016 09:51:01 -0700
Subject: Re: [PATCH] PR78879
Authentication-results: sourceware.org; auth=none
References: <327336c5.30f56.1592524b634.Coremail.ypf@pku.edu.cn>

On 12/21/2016 11:08 PM, Yuan, Pengfei wrote:

Hi,

The following patch fixes
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78879

There are some other invocations of unordered_remove in
tree-ssa-threadupdate.c, which may also need to be replaced
with ordered_remove.

Regards,
Yuan, Pengfei


2016-12-22  Yuan Pengfei  <ypf@pku.edu.cn>

	PR middle-end/78879
	* tree-ssa-threadupdate.c (mark_threaded_blocks): Replace
	unordered_remove with ordered_remove.

How specifically does this fix the problem. I suspect you're justpapering over the bug by changing the order of thread processing.

You'll note that when a thread is canceled we call thepaths.unordered_remove without incrementing i. AFAICT you're justchanging order in which paths out of the array.



Jeff

Follow-Ups:
- Re: [PATCH] PR78879
  - From: Yuan, Pengfei

References:
- [PATCH] PR78879
  - From: Yuan, Pengfei

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]