This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v4] Run tests only if the machine supports the instruction set.
On Tue, Dec 20, 2016 at 10:32:26PM +0100, Jakub Jelinek wrote:
> On Tue, Dec 20, 2016 at 10:26:13PM +0100, Dominik Vogt wrote:
> > On Tue, Dec 20, 2016 at 11:57:52AM -0800, Mike Stump wrote:
> > > On Dec 20, 2016, at 6:10 AM, Dominik Vogt <vogt@linux.vnet.ibm.com> wrote:
> > > > Right, it gets called even more often than one would think, and
> > > > even with empty torture_current_options. The attached new patch
> > > > (v3) removes -Ox options and superflous whitespace and caches that
> > > > between calls if it's not empty. There's another, permanent cache
> > > > for calls without any flags. With proper ordering of the torture
> > > > options, the test program is built only a couple of times.
> > >
> > > Seems fine to me, but most other cases use the postfix _hw. Any
> > > reason not use use _hw (and not _runable) on these? If not,
> > > could you please use _hw instead.
> >
> > No specific reason other than lack of imagination. "s390_hw" is a
> > bit too generic in my eyes -> the new names are:
> >
> > v4:
> >
> > * Renamed "s390_runnable" to "s390_useable_hw".
> > * Renamed "z900_runnable" to "s390_z900_hw",
> > Renamed "z10_runnable" to "s390_z10_hw",
> > etc.
>
> Grepping for _hw in target-supports.exp reveals that usually the
> effective target predicates are called <isa>_hw or <isa>_hw_available,
> <target>_<isa>_hw only if it is too ambiguous (e.g. alpha_max_hw or
> ppc_float128_hw_available). So I think z900_hw, z10_hw etc. is good
> enough (as long as it does not clash with some other target isa name),
> s390_usable_hw or s390_hw_available is fine.
Okay. We usually prefix everyting with "s390_" on S/390, so I'd
say we don't make an exception here - even if there are no
potential naming collisions.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany