Re: [PATCH, GCC/testsuite/ARM] Skip optional_mthumb tests if GCC has a default mode

[Christophe Lyon <christophe dot lyon at linaro dot org>]

Hi Thomas,

Thanks for working on this,


On 12 December 2016 at 18:52, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> Hi,
>
> The logic to make -mthumb optional for Thumb-only devices is only executed
> when no -marm or -mthumb is given on the command-line. This includes
> configuring GCC with --with-mode= because this makes the option to be passed
> before any others. The optional_mthumb-* testcases are skipped when -marm or
> -mthumb is passed on the command line but not when GCC was configured with
> --with-mode. Not only are the tests meaningless in these configurations,
> they also spuriously FAIL if --with-mode=arm was used since the test are
> built for Thumb-only devices, as reported by Christophe Lyon in [1].
>
> [1] https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02082.html
>
> This patch adds logic to target-support.exp to check how was GCC configured
> and changes the optional_mthumb testcases to be skipped if there is a
> default mode (--with-mode=). It also fixes a couple of typo on the
> selectors.
>

How hard would it be to skip these tests only if --with-mode=arm,
such that they would still pass in configurations --with-mode=thumb?

It seems easy to extend what you propose here, doesn't it?

Christophe

> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2016-12-09  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
>         * lib/target-supports.exp (check_configured_with): New procedure.
>         (check_effective_target_default_mode): new effective target.
>         * gcc.target/arm/optional_thumb-1.c: Skip if GCC was configured with
> a
>         default mode.  Fix dg-skip-if target selector syntax.
>         * gcc.target/arm/optional_thumb-2.c: Likewise.
>         * gcc.target/arm/optional_thumb-3.c: Fix dg-skip-if target selector
>         syntax.
>
>
> Is this ok for stage3?
>
> Best regards,
>
> Thomas