Re: [PATCH v2] PR target/78748: S/390: Fix ICE with ANDC splitter.

[Dominik Vogt <vogt at linux dot vnet dot ibm dot com>]

On Mon, Dec 12, 2016 at 03:50:14PM +0100, Jakub Jelinek wrote:
> On Mon, Dec 12, 2016 at 03:36:01PM +0100, Dominik Vogt wrote:
> > diff --git a/gcc/testsuite/gcc.c-torture/compile/pr78748.c b/gcc/testsuite/gcc.c-torture/compile/pr78748.c
> > new file mode 100644
> > index 0000000..d24a334
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.c-torture/compile/pr78748.c
> > @@ -0,0 +1,16 @@
> > +/* PR target/78748 */
> > +/* { dg-options "-march=zEC12" { target { s390*-*-* } } } */
> > +
> > +void
> > +foo (int *p, int *q)
> > +{
> > +  *q = *p & ~*q;
> > +}
> > +
> > +#if 0 /*!!!*/
> > +void
> > +bar (int *p, int *q)
> > +{
> > +  *q = ~*p & *q;
> > +}
> > +#endif
> 
> Why the #if 0 /*!!!*/?

The "!!!" is a to-do-marker.  When doing too many things in
parallel I sometimes forget removing them.  Sorry for that.  Patch
without the marker attached.

> The test just verifies the compiler doesn't ICE
> and stuff assembles,

> I'd hope bar also compiles and assembles.

It does, with and without the patch.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany

Attachment: 0001-v2-ChangeLog
Description: Text document

Attachment: 0001-v2-PR-target-78748-S-390-Fix-ICE-with-ANDC-splitter.patch
Description: Text document