This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Fortran, pr78672, ctp1, v2] Gfortran test suite failures with a sanitized compiler
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Andre Vehreschild <vehre at gmx dot de>
- Cc: Mikael Morin <morin-mikael at orange dot fr>, GCC-Patches-ML <gcc-patches at gcc dot gnu dot org>, GCC-Fortran-ML <fortran at gcc dot gnu dot org>, Dominique Dhumieres <dominiq at lps dot ens dot fr>, Jerry DeLisle <jvdelisle at charter dot net>
- Date: Sun, 11 Dec 2016 15:49:33 +0100
- Subject: Re: [PATCH, Fortran, pr78672, ctp1, v2] Gfortran test suite failures with a sanitized compiler
- Authentication-results: sourceware.org; auth=none
- References: <20161208143937.0153b2a8@vepi2> <f7aa9fc0-7e1f-4e05-d22a-48bf44408b8d@orange.fr> <20161209115519.12f1422b@vepi2> <848d42c4-21a1-6414-b942-dce80220d539@orange.fr> <20161211140137.5174fcca@vepi2>
Hi Andre,
Thanks for doing this work with the instrumented compiler. It was a
great help with PR78350.
As for the patch - OK for trunk.
Paul
On 11 December 2016 at 14:01, Andre Vehreschild <vehre@gmx.de> wrote:
> Hi Mikael, hi Jerry, hi Steve, hi Jane, hi Thomas, hi Paul, hi all,
>
> thanks for all the input you gave on the patch I have present. I tried to
> address all of it in the new version of the patch attached.
>
> Mikael: data.c::create_character_initializer()
> I have remove the test for rvalue->value.character.string and went to
> gfc_assign_data_value () line 483 to prevent calling the routine when rvalue is
> not an EXPR_CONSTANT (third chunk of the patch).
>
> interface.c::compare_actual_formal()
> I have reverted the change to look at actual_arr_ref when looking for assumed
> size arrays which are dummy argument arrays. That chunk (#5) is now only
> additionally checking whether f.sym is really of type BT_CHARACTER before
> accessing its ts.u.cl.lenght.
>
> For the second occurrence of actual_arr_ref I have extended
> gfc_find_array_ref() with a flag to pass the search when no array ref is found
> (Chunks #1, 2 and 6).
>
> Jerry: trans-expr.c::gfc_conv_cst_int_power()
> I have added comment to new C++ code. Would you like to add something to it?
>
> The updated patch bootstraps and regtests fine on x86_64-linux/f23 on a regular
> and on an instrumented gfortran. How do you like this patch?
>
> Regards,
> Andre
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
--
If you're walking down the right path and you're willing to keep
walking, eventually you'll make progress.
Barack Obama
- References:
- [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler
- Re: [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler
- Re: [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler
- Re: [PATCH, Fortran, pr78672, ctp1, v1] Gfortran test suite failures with a sanitized compiler
- Re: [PATCH, Fortran, pr78672, ctp1, v2] Gfortran test suite failures with a sanitized compiler