Re: [ARM][PATCH] Fix failing poly64 tests on ARM

[Christophe Lyon <christophe dot lyon at linaro dot org>]

Sending again, after removing ARM's "company disclaimer or privacy notice"...


On 8 December 2016 at 10:03, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> Hi,
>
> On 6 December 2016 at 11:55, Tamar Christina <Tamar.Christina@arm.com> wrote:
>> Hi Christophe,
>>
>> Aarch64 seems to still pass. It seems the types are really unused after I moved the other tests to p64_p128.
>>
>
> I checked the attached patch fixes the failing tests on ARM/AArch64
> (no advsimd-intrinsic test
> fail after this patch is applied).
>
> OK for trunk?
>
> Thanks,
>
> Christophe
>
>
>> Thanks,
>> Tamar
>>
>> ________________________________________
>> From: Christophe Lyon <christophe.lyon@linaro.org>
>> Sent: Monday, December 5, 2016 6:33:43 PM
>> To: Kyrill Tkachov
>> Cc: Tamar Christina; GCC Patches; nickc@redhat.com; Richard Earnshaw
>> Subject: Re: [ARM][PATCH] Fix failing poly64 tests on ARM
>>
>> Hi Tamar,
>>
>>
>> On 5 December 2016 at 16:32, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
>>>
>>> On 05/12/16 10:39, Tamar Christina wrote:
>>>>
>>>> Hi All,
>>>>
>>>> This patch fixes test failures on arm-none-eabi.
>>>> Poly64 was being used by files that were not supposed
>>>> to be testing poly64 types.
>>>>
>>>> I have added a new MACRO that must be defined in addition
>>>> to having CRYPTO available before use of Poly64 types are
>>>> allowed in the header arm-neon-ref.h.
>>>>
>>>> Ok for trunk?
>>>>
>>>> gcc/testsuite/
>>>> 2016-12-01  Tamar Christina  <tamar.christina@arm.com>
>>>>
>>>>         * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h: Gate use
>>>> of Poly64 on USE_CRYPTO_TYPES.
>>>>         * gcc.target/aarch64/advsimd-intrinsics/p64_p128.c: Define
>>>> USE_CRYPTO_TYPES.
>>>>         * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p128.c:
>>>> Likewise.
>>>>         * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p64.c:
>>>> Likewise.
>>>
>>>
>>> Ok, but please make sure the line length in the ChangeLog doesn't go over 80
>>> characters.
>>> Kyrill
>>
>> Since 'expected_poly64x[12]' isn't used, there is no need to declare it,
>> and the attached patch seems to work (tested only on arm-none-linux-gnueabihf
>> --target-board=-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard
>>
>> All the tests for poly64 use dedicated output buffers, at least for the moment.
>>
>> Does my patch break aarch64?
>>
>> Christophe

Attachment: poly64.log.txt
Description: Text document

Attachment: poly64.patch.txt
Description: Text document