This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] pr65479 Add -fasynchronous-unwind-tables when the -fsanitize=address option is seen
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>, Bill Seurer <seurer at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 7 Dec 2016 09:51:12 -0600
- Subject: Re: [PATCH, rs6000] pr65479 Add -fasynchronous-unwind-tables when the -fsanitize=address option is seen
- Authentication-results: sourceware.org; auth=none
- References: <39413c1c-a91f-3038-df8f-96ca142f2eb9@linux.vnet.ibm.com> <b8f072f0-96de-1a10-638f-c1a1191aac05@linux.vnet.ibm.com> <20161206215554.GI2767@gate.crashing.org>
On 12/6/16 3:55 PM, Segher Boessenkool wrote:
> On Tue, Dec 06, 2016 at 03:23:06PM -0600, Bill Seurer wrote:
>> --- gcc/config/rs6000/rs6000.c (revision 243308)
>> +++ gcc/config/rs6000/rs6000.c (working copy)
>> @@ -5204,6 +5204,11 @@ rs6000_option_override (void)
>> {
>> (void) rs6000_option_override_internal (true);
>>
>> + /* -fsanitize=address needs to turn on -fasynchronous-unwind-tables for
>> + ppc64 in order for tracebacks to be complete. */
>> + if (global_options.x_flag_sanitize & SANITIZE_USER_ADDRESS)
>> + global_options.x_flag_asynchronous_unwind_tables = 1;
>
> Do you need to check if the user specified -fno-asynchronous-unwind-tables
> here, and then not do this? I.e. similar to the rs6000_isa_flags_explicit
> handling (in the _internal function).
I agree that if the user explicitly says -fno-asynchronous-unwind-tables,
we shouldn't implicitly enable it behind their back.
I also don't see how this is ppc64 specific, but your comment mentions
it. The way the code is written here, this will be used for ppc32, ppc64
and ppc64le. I'd just rewrite the comment without mentioning ppc64 or
replace it with a more general term (PowerPC?).
Peter