This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR fortran/78618 -- RANK() should not ICE
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: kargl at uw dot edu
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 2 Dec 2016 16:47:19 +0100
- Subject: Re: [PATCH] PR fortran/78618 -- RANK() should not ICE
- Authentication-results: sourceware.org; auth=none
- References: <20161202013354.GA42106@troutmask.apl.washington.edu>
Hi Steve,
2016-12-02 2:33 GMT+01:00 Steve Kargl <sgk@troutmask.apl.washington.edu>:
> The attached patch fixes an ICE, a nearby whitespace issue, and
> removed the ATTRIBUTE_UNUSED tag. THe change has passed regression
> testing on x86_64-*-freebsd. Ok to commit?
huh, I don't really understand why the argument of RANK is detected to
be an EXPR_FUNCTION for the test case at hand. Shouldn't it rather be
an EXPR_CONSTANT?
Some debugging in gfc_check_rank shows that a->symtree->n.sym indeed
is the symbol "c" (as expected), but that clearly is not a function,
so it seems to me that the actual bug here is that a->expr_type is set
incorrectly ...?
Cheers,
Janus
> 2016-12-01 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/78618
> * check.c (gfc_check_rank): Remove ATTRIBUTE_UNUSED. Fix whitespace.
> Fix ICE where a NULL pointer is dereferenced.
> * simplify.c (gfc_convert_char_constant): Do not buffer error.
>
> 2016-12-01 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/78618
> * gfortran.dg/char_conversion.f90: New test.
>
> --
> Steve