This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix x86_64 fix_debug_reg_uses (PR rtl-optimization/78575)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 2 Dec 2016 00:14:35 +0100
- Subject: Re: [PATCH] Fix x86_64 fix_debug_reg_uses (PR rtl-optimization/78575)
- Authentication-results: sourceware.org; auth=none
- References: <20161129194158.GI3541@tucnak.redhat.com> <f94cfcc7-b361-0614-9780-daeb41036c41@redhat.com> <20161130185736.GY3541@tucnak.redhat.com> <905a3b37-34c2-e3d3-0876-b91d10b847f1@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Dec 01, 2016 at 03:55:58PM -0700, Jeff Law wrote:
> On 11/30/2016 11:57 AM, Jakub Jelinek wrote:
> >On Tue, Nov 29, 2016 at 03:20:08PM -0700, Jeff Law wrote:
> >>On 11/29/2016 12:41 PM, Jakub Jelinek wrote:
> >>>Hi!
> >>>
> >>>The x86_64 stv pass uses PUT_MODE to change REGs and MEMs in place to affect
> >>>all setters and users, but that is undesirable in debug insns which are
> >>>intentionally ignored during the analysis and we should keep using correct
> >>>modes (TImode) instead of the new one (V1TImode).
> >>Note that MEMs are not shared, so twiddling the mode on any given MEM
> >>changes one and only one object.
> >
> >Note that this patch isn't trying to workaround any wrong MEM sharing,
> >while the other patch has been. So, is the PR78575 ok as is?
> >I'll post the other updated patch in the corresponding thread.
> It was an x86 patch, right? So it's Uros's call.
Yeah, it is config/i386/ only.
Jakub