This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change

From: Aldy Hernandez <aldyh at redhat dot com>
To: gcc-patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, Andreas Schwab <schwab at linux-m68k dot org>
Date: Tue, 29 Nov 2016 11:33:51 -0500
Subject: [PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change
Authentication-results: sourceware.org; auth=none

This fixes the gcc.dg/uninit-pred-6* failures I seem to have caused onsome non x86 platforms. Sorry for the delay.

The problem is that my fix for PR61409 had the logic backwards. I wasproving that all the uses of a PHI are invalidated by any one undefinedPHI path, whereas what we want is to prove that EVERY uninitialized pathis invalidated by some facor in the PHI use.

The attached patch fixes this without causing any regressions on x86-64Linux. I also verified that at least on [arm-none-linux-gnueabihf--with-cpu=cortex-a5 --with-fpu=vfpv3-d16-fp16], there are nogcc.dg/*uninit* regressions.

There is still one regression at large involving a double free inPR78548 which I will look at next/independently.


OK for trunk?
Aldy

Attachment: curr
Description: Text document

Follow-Ups:
- Re: [PR middle-end/78566] Fix uninit regressions caused by previous -Wmaybe-uninit change
  - From: Christophe Lyon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]