This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts
On Tue, Nov 29, 2016 at 08:27:04PM +0800, Chung-Lin Tang wrote:
> On 2016/11/18 7:23 PM, Jakub Jelinek wrote:
> > On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote:
> >> Updated C/C++ front-end patches, adjusted as reviewed.
> >
> > Jason is right, finish_omp_clauses will verify the tile operands
> > when !processing_template_decl are non-negative host INTEGER_CSTs,
> > so can't you just tsubst it like OMP_CLAUSE_COLLAPSE? If the operand
> > is not a constant expression, presumably it will not be INTEGER_CST.
>
> Yeah, it appears that way will work. Updated C/C++ FE patch as attached.
>
> > On the other side, OMP_CLAUSE_TILE has now 3 operands instead of just 1,
> > don't you need to do something during instantiation for the other 2
> > operands?
> >
> > Jakub
>
> The other two operands are used only in omp-low, they're not programmer
> defined operands.
Ok, thanks.
Jakub