This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2 v3] PR77822


On 11/25/2016 01:29 AM, Dominik Vogt wrote:
On Thu, Nov 24, 2016 at 08:33:32AM -0700, Jeff Law wrote:
On 11/24/2016 02:59 AM, Dominik Vogt wrote:
On Wed, Nov 23, 2016 at 01:22:31PM -0700, Jeff Law wrote:
	PR target/77822
	* system.h (SIZE_POS_IN_RANGE): New.
OK.  Though system.h seems like an unfortunate place.  Would rtl.h
work better since this is really about verifying the arguments to
things like {zero,sign}_extract which are RTL concepts.

I was unsure whether it's better to give the macro a name not
related to *_extract and put it into system.h or make it specific
to extracts and put it in rtl.h.
Yea.  What tends to tip the balance for me is that it's likely not
reusable outside extraction argument testing.


It's probably not really reuseable elsewhere, so when moving it to
rtl.h I'll also rename it to EXTRACT_ARGS_IN_RANGE.  Okay?
Yea, that sounds perfect.

Version 4 of the patch attached.  Bootstrapped and regression
tested on s390x biarch and s390.  Changes since the last version:

v4:
	Rename SIZE_POS_IN_RANGE to EXTRACT_ARGS_IN_RANGE and move
	it to rtl.h.
OK for the trunk -- just in case you were waiting on an explicit ack of V4.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]