This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't use priority {cd}tors if not supported by a target (PR, gcov-profile/78086)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, danglin at gcc dot gnu dot org, Nathan Sidwell <nathan at acm dot org>
- Date: Fri, 25 Nov 2016 11:47:50 +0100
- Subject: Re: [PATCH] Don't use priority {cd}tors if not supported by a target (PR, gcov-profile/78086)
- Authentication-results: sourceware.org; auth=none
- References: <4b281a98-6567-95ac-6695-0fe963c7d79d@suse.cz>
> Hi.
>
> Using priority {cd}tors on a target that does not support that can cause failures (see the PR).
> Apart from that, I decided to use priority 100 for both gcov_init and gcov_exit functions as
> the reserved range includes priority 100. Moreover, I enhanced test-cases we have.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
> >From 05a0dcb13d608facdd1c85f4101cd821634d07cd Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Wed, 26 Oct 2016 12:50:35 +0200
> Subject: [PATCH] Don't use priority {cd}tors if not supported by a target (PR
> gcov-profile/78086)
>
> gcc/testsuite/ChangeLog:
>
> 2016-10-26 Martin Liska <mliska@suse.cz>
>
> * g++.dg/gcov/pr16855.C: Clean up the test case.
> * g++.dg/gcov/pr16855-priority.C: New test.
>
> gcc/ChangeLog:
>
> 2016-10-26 Martin Liska <mliska@suse.cz>
>
> * coverage.c (build_init_ctor): Don't use priority {cd}tors if
> not supported by a target. Set priority to 100 if possible.
> (build_gcov_exit_decl): Likewise.
OK,
thanks!
Honza