This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GCC][AArch64][PATCH][Testsuite] Fix failing test vector_initialization_nostack.c
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, nd <nd at arm dot com>
- Date: Fri, 25 Nov 2016 10:23:38 +0000
- Subject: Re: [GCC][AArch64][PATCH][Testsuite] Fix failing test vector_initialization_nostack.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com;
- Nodisclaimer: True
- References: <VI1PR0801MB20313580A29473C52721B5BEFFA70@VI1PR0801MB2031.eurprd08.prod.outlook.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, Nov 07, 2016 at 02:05:27PM +0000, Tamar Christina wrote:
> Hi all,
>
> This fixes (PR78142) by turning off scheduling for the test.
> r241590 is causing more registers to be used and so
> the SP registered happens to be picked and used.
>
> This test I believe was checking explicitly that the
> SP is not used if not needed.
I can't say I'm convinced by the fix - turning off passes to work around
a failure suggests a problem with the test, and turning off the pass reduces
coverage of what we're actually trying to test for.
Can the test be rewritten to only require construction of one vector in
the char case?
Thanks,
James
> gcc/testsuite/
>
> 2016-11-07 Tamar Christina <tamar.christina@arm.com>
>
> PR middle-end/78142
> * gcc.target/aarch64/vector_initialization_nostack.c
> (dg-options): Disabled scheduling.
> diff --git a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c
> index bbad04d00263b6a91b826b4911af92bdd226c821..71699281c5ce79fb5cf37e47b8ba078721c19f3a 100644
> --- a/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c
> +++ b/gcc/testsuite/gcc.target/aarch64/vector_initialization_nostack.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model" } */
> +/* { dg-options "-O3 -ftree-vectorize -fno-vect-cost-model -fno-schedule-insns" } */
> float arr_f[100][100];
> float
> f9 (void)