This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite]: Fix detection of -j make argument

On Tue, Nov 22, 2016 at 4:54 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Tue, 22 Nov 2016, Uros Bizjak wrote:
>
>> New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a
>> different way. While older makes pass only "-j", newer makes pass e.g.
>> "-j4" when -j is specified on the command line. The detection of "-j"
>> make argument doesn't work in the later case.
>>
>> Attached patch reworks this functionality to detect -j correctly in all
>> cases.
>
>
> Hello,
>
> I didn't read the patch, but do you think this also fixes PR 53155 ?

 Looking at the PR, I don't think so - but I did test my patch with
CentOS 5.11 (with make 3.81) and detection worked there without
problems.

Maybe MAKEFLAGS should be used instead of MFLAGS, since docs mentions
that MFLAGS is intended for historical compatibility?

[1] https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html

Uros.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]