This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Delete GCJ
- From: Matthias Klose <doko at ubuntu dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>, Iain Sandoe <iain at codesourcery dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, Jeff Law <law at redhat dot com>, Andrew Haley <aph at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, GCJ-patches <java-patches at gcc dot gnu dot org>
- Date: Mon, 21 Nov 2016 17:40:36 +0100
- Subject: Re: [PATCH] Delete GCJ
- Authentication-results: sourceware.org; auth=none
- References: <78f841e7-808b-58d0-7913-3ec0d19630a0@redhat.com> <4deb7e45-e428-d819-aabc-748abe8f7686@redhat.com> <0E421C5A-7EF5-4182-A13B-BF9AEAF90215@comcast.net> <6DA7C7D0-314E-4A5E-8B35-5A8EA2F74CD8@mentor.com> <c5c6794b-d73b-6898-1fef-95e8caacac28@redhat.com> <2b5de569-1efd-f407-49c2-c9fa84cc5315@ubuntu.com> <4964955d-4de1-618c-de41-835ca19f9932@ubuntu.com> <yddvax5a0og.fsf@CeBiTec.Uni-Bielefeld.DE> <4FBA6B16-460A-4EBB-8809-0883A84ABEB7@mentor.com> <0bf14402-d4e6-5fb0-8a63-479903ed2141@ubuntu.com> <yddr37ta01s.fsf@CeBiTec.Uni-Bielefeld.DE> <01B885DF-4340-43C6-A784-21326A9CA8CF@comcast.net> <10704c8f-fd72-8d13-17a1-f522e88345b2@ubuntu.com> <CDB6E3C7-0AB6-4394-BD88-D5AB2325DCE5@mentor.com> <31916070-ce2d-423a-e942-33f0b3ebc227@ubuntu.com> <6747724B-4128-4C55-8625-91AA559A0D98@mentor.com> <885027a6-080b-ec6f-89df-533be4132b36@ubuntu.com> <41C15B32-0659-49F2-A918-8A83623E4BF8@codesourcery.com> <48b62bc3-2870-0113-d165-59057c186e54@ubuntu.com> <58331F83.9080801@codesourcery.com>
On 21.11.2016 17:23, Sandra Loosemore wrote:
> On 11/21/2016 05:57 AM, Matthias Klose wrote:
>>
>> --with-target-bdw-gc=/opt/bdw-gc,32=/opt/bdw-gc32
>>
>> sets the include and lib dirs by appending include and lib to the paths. If you
>> have options --with-target-bdw-gc-include= and --with-target-bdw-gc-lib= as
>> well, it overrides the settings done in --with-target-bdw-gc=. This is copied
>> from the setting of the gmp/mpfr options.
>>
>> Any of these options override the automatic discovery using pkg-config.
>>
>> Please suggest a better wording; I thought that was clear enough (and better
>> than the undocumented --enable-libobjc-gc anyway ;)
>
> FAOD, my complaint about your patch is that it essentially said
>
> "The options --with-foo and --with-foo must also be specified together and
> override --with-foo."
>
> I'm sure you didn't mean exactly the same --with-foo in all 3 places, but I'm a
> dummy about what you really intended to say here.
ahh, didn't see that :-/ Now fixed, is this clearer now?
The options @option{--with-target-bdw-gc-include} and
@option{--with-target-bdw-gc-lib} must always specified together for
each multilib variant and take precedence over
@option{--with-target-bdw-gc}. If none of these options are
specified, the values are taken from the @command{pkg-config}
@samp{bdw-gc} module.
Matthias