This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Add built-in support for vector compare listed in the ABI
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: "Carl E. Love" <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Bill Schmidt <wschmidt at us dot ibm dot com>
- Date: Thu, 17 Nov 2016 15:47:37 -0600
- Subject: Re: [PATCH, rs6000] Add built-in support for vector compare listed in the ABI
- Authentication-results: sourceware.org; auth=none
- References: <1479417597.4523.236.camel@us.ibm.com>
Hi Carl,
On Thu, Nov 17, 2016 at 01:19:57PM -0800, Carl E. Love wrote:
> 2016-11-15 Carl Love <cel@us.ibm.com>
Two spaces between your name and email address.
> * gcc.target/powerpc/builtins-3.c : New file to test the new
No space before colon.
> built-ins for vecotr compare equal and vector compare not equal.
Typo ("vecotr"). Changelog is indented with tabs btw, not spaces.
> { ALTIVEC_BUILTIN_VEC_CMPEQ, ALTIVEC_BUILTIN_VCMPEQUW,
> RS6000_BTI_bool_V4SI, RS6000_BTI_unsigned_V4SI, RS6000_BTI_unsigned_V4SI, 0 },
> { ALTIVEC_BUILTIN_VEC_CMPEQ, P8V_BUILTIN_VCMPEQUD,
> + RS6000_BTI_bool_V2DI, RS6000_BTI_bool_V2DI, RS6000_BTI_bool_V2DI, 0 },
> +
> + { ALTIVEC_BUILTIN_VEC_CMPEQ, P8V_BUILTIN_VCMPEQUD,
> RS6000_BTI_bool_V2DI, RS6000_BTI_V2DI, RS6000_BTI_V2DI, 0 },
> { ALTIVEC_BUILTIN_VEC_CMPEQ, P8V_BUILTIN_VCMPEQUD,
> RS6000_BTI_bool_V2DI, RS6000_BTI_unsigned_V2DI, RS6000_BTI_unsigned_V2DI, 0 },
Why the blank line?
Otherwise looks fine. Thanks,
Segher