This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2 1/2, i386] cmpstrnsi needs string length
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Aaron Sawdey <acsawdey at linux dot vnet dot ibm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Kaz Kojima <kkojima at gcc dot gnu dot org>, olegendo at gcc dot gnu dot org, Nick Clifton <nickc at redhat dot com>, Jeff Law <law at redhat dot com>, Uros Bizjak <ubizjak at gmail dot com>, DavidEdelsohn <dje dot gcc at gmail dot com>
- Date: Thu, 17 Nov 2016 12:09:06 +0100
- Subject: Re: [PATCH v2 1/2, i386] cmpstrnsi needs string length
- Authentication-results: sourceware.org; auth=none
- References: <1479324140.6279.30.camel@linux.vnet.ibm.com>
On 11/16/2016 08:22 PM, Aaron Sawdey wrote:
I've also changed the pattern to indicate that operand 3 may
be clobbered (if it happens to be in cx already).
That part looks like a meaningless change since the pattern in that
define_expand is never used (there's a DONE at the end).
I don't think this is really a concern anyway (the pattern checks for CX
in fixed_regs) and I suspect we wouldn't get a hard register in this
expander in other cases.
Other than that it looks OK to me, please wait a day or two to see if
Uros has objections.
Bernd