This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

From: Mike Stump <mikestump at comcast dot net>
To: Tamar Christina <Tamar dot Christina at arm dot com>
Cc: Andreas Schwab <schwab at suse dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "ro at CeBiTec dot Uni-Bielefeld dot DE" <ro at CeBiTec dot Uni-Bielefeld dot DE>, nd <nd at arm dot com>
Date: Wed, 16 Nov 2016 10:58:32 -0800
Subject: Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
Authentication-results: sourceware.org; auth=none
References: <VI1PR0801MB2031B2941A1620AC227B4593FFA10@VI1PR0801MB2031.eurprd08.prod.outlook.com> <4B6D15EB-C979-4162-BCF1-EE29C9BCFAAF@comcast.net> <mvm1syb5vyn.fsf@hawking.suse.de> <VI1PR0801MB2031FB3B4E16B06968DDA7C2FFBE0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <VI1PR0801MB2031EFF8BDA470D4DD32360FFFBE0@VI1PR0801MB2031.eurprd08.prod.outlook.com>

On Nov 16, 2016, at 7:57 AM, Tamar Christina <Tamar.Christina@arm.com> wrote:
> 
> Forgot to include the committed patch.

>>> This is causing all test names to depend on $srcdir.  A test name
>>> should never include the value of $srcdir.
>> 
>> Sorry about that, committed a fix as r242500 under the obvious rule.

Yeah, I easily could have approved it as well, so no worries.

The patch is Ok.

The way I usually catch this would be in reviewing the output of ./contrib/compare_tests, it would complain about a ton of new tests now not passing, which is a dead giveaway.

Follow-Ups:
- Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Mike Stump

References:
- [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Tamar Christina
- Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Mike Stump
- Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Andreas Schwab
- RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Tamar Christina
- RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
  - From: Tamar Christina

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]