This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/8] NVPTX offloading to NVPTX: backend patches
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Nathan Sidwell <nathan at acm dot org>
- Date: Fri, 11 Nov 2016 18:35:53 +0300 (MSK)
- Subject: Re: [PATCH 0/8] NVPTX offloading to NVPTX: backend patches
- Authentication-results: sourceware.org; auth=none
- References: <1476463189-22540-1-git-send-email-amonakov@ispras.ru> <6e6106d4-3ae9-54e2-c1d3-99a2580297dc@redhat.com> <alpine.LNX.2.20.13.1610171908030.16847@monopod.intra.ispras.ru> <e49fee7b-183b-818d-2740-251d2b54ed7e@redhat.com> <alpine.LNX.2.20.13.1610181619460.16847@monopod.intra.ispras.ru> <e1fa737e-f333-3992-9117-7eed285a2025@redhat.com> <5d68fe3b-1993-9b57-c6f4-cd8d627c2ad7@redhat.com>
On Fri, 11 Nov 2016, Bernd Schmidt wrote:
> On 10/19/2016 12:39 PM, Bernd Schmidt wrote:
> > I'll refrain from any further comments on the topic. The ptx patches
> > don't look unreasonable iff someone else decides that this version of
> > OpenMP support should be merged and I'll look into them in more detail
> > if that happens. Patch 2/8 is ok now.
>
> Sounds like Jakub has made that decision. So I'll get out of the way and just
> approve all these.
For the avoidance of doubt, is this a statement of intent, or an actual approval
for the patchset?
After these backend modifications and the rest of libgomp/middle-end changes are
applied, trunk will need the following flip-the-switch patch to allow OpenMP
offloading for NVPTX. OK?
Thanks.
Alexander
PR target/67822
* config/nvptx/mkoffload.c (main): Allow -fopenmp.
diff --git a/gcc/config/nvptx/mkoffload.c b/gcc/config/nvptx/mkoffload.c
index c8eed45..e99ef37 100644
--- a/gcc/config/nvptx/mkoffload.c
+++ b/gcc/config/nvptx/mkoffload.c
@@ -517,8 +524,8 @@ main (int argc, char **argv)
fatal_error (input_location, "cannot open '%s'", ptx_cfile_name);
/* PR libgomp/65099: Currently, we only support offloading in 64-bit
- configurations. PR target/67822: OpenMP offloading to nvptx fails. */
- if (offload_abi == OFFLOAD_ABI_LP64 && !fopenmp)
+ configurations. */
+ if (offload_abi == OFFLOAD_ABI_LP64)
{
ptx_name = make_temp_file (".mkoffload");
obstack_ptr_grow (&argv_obstack, "-o");