This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Support no newline in print_gimple_stmt
On 11/11/2016 01:10 PM, Richard Biener wrote:
> On Thu, Nov 10, 2016 at 4:36 PM, Martin Liška <mliska@suse.cz> wrote:
>> I've just noticed that tree-ssa-dse wrongly prints a new line to dump file.
>> For the next stage1, I'll go through usages of print_gimple_stmt and remove
>> extra new lines like:
>>
>> gcc/auto-profile.c: print_gimple_stmt (dump_file, stmt, 0, TDF_SLIM);
>> gcc/auto-profile.c- fprintf (dump_file, "\n");
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>
> Err, why not just remove the excess newlines (and drop the ' quotes)?
OK, let's do it simple ;) There's a new output:
Deleted dead store: *p_2(D) = 0;
Ready to install the patch after it finishes regression tests?
Thanks,
Martin
>
> Richard.
>
>> Martin
>From c781ca49f502b205d55f411051a3e9881d2c9d7b Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Fri, 11 Nov 2016 15:51:22 +0100
Subject: [PATCH] Fix dump output in dse_optimize_stmt
gcc/ChangeLog:
2016-11-11 Martin Liska <mliska@suse.cz>
* tree-ssa-dse.c (dse_optimize_stmt): Remove quotes and extra
new line.
---
gcc/tree-ssa-dse.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/tree-ssa-dse.c b/gcc/tree-ssa-dse.c
index 372a0be..778b363 100644
--- a/gcc/tree-ssa-dse.c
+++ b/gcc/tree-ssa-dse.c
@@ -236,9 +236,9 @@ dse_optimize_stmt (gimple_stmt_iterator *gsi)
if (dump_file && (dump_flags & TDF_DETAILS))
{
- fprintf (dump_file, " Deleted dead call '");
+ fprintf (dump_file, " Deleted dead call: ");
print_gimple_stmt (dump_file, gsi_stmt (*gsi), dump_flags, 0);
- fprintf (dump_file, "'\n");
+ fprintf (dump_file, "\n");
}
tree lhs = gimple_call_lhs (stmt);
@@ -292,9 +292,9 @@ dse_optimize_stmt (gimple_stmt_iterator *gsi)
if (dump_file && (dump_flags & TDF_DETAILS))
{
- fprintf (dump_file, " Deleted dead store '");
+ fprintf (dump_file, " Deleted dead store: ");
print_gimple_stmt (dump_file, gsi_stmt (*gsi), dump_flags, 0);
- fprintf (dump_file, "'\n");
+ fprintf (dump_file, "\n");
}
/* Then we need to fix the operand of the consuming stmt. */
--
2.10.1