This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libiberty: Add Rust symbol demangling.
- From: Ian Lance Taylor <iant at google dot com>
- To: Mark Wielaard <mark at klomp dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, David Tolnay <dtolnay at gmail dot com>, Tom Tromey <tom at tromey dot com>, Julian Seward <jseward at acm dot org>
- Date: Fri, 11 Nov 2016 07:01:43 -0800
- Subject: Re: [PATCH] libiberty: Add Rust symbol demangling.
- Authentication-results: sourceware.org; auth=none
- References: <1478194787-27863-1-git-send-email-mark@klomp.org>
On Thu, Nov 3, 2016 at 10:39 AM, Mark Wielaard <mark@klomp.org> wrote:
>
> include/ChangeLog:
>
> 2016-11-03 David Tolnay <dtolnay@gmail.com>
> Mark Wielaard <mark@klomp.org>
>
> * demangle.h (DMGL_RUST): New macro.
> (DMGL_STYLE_MASK): Add DMGL_RUST.
> (demangling_styles): Add dlang_rust.
> (RUST_DEMANGLING_STYLE_STRING): New macro.
> (RUST_DEMANGLING): New macro.
> (rust_demangle): New prototype.
> (rust_is_mangled): Likewise.
> (rust_demangle_sym): Likewise.
>
> libiberty/ChangeLog:
>
> 2016-11-03 David Tolnay <dtolnay@gmail.com>
> Mark Wielaard <mark@klomp.org>
>
> * Makefile.in (CFILES): Add rust-demangle.c.
> (REQUIRED_OFILES): Add rust-demangle.o.
> * cplus-dem.c (libiberty_demanglers): Add rust_demangling case.
> (cplus_demangle): Handle RUST_DEMANGLING.
> (rust_demangle): New function.
> * rust-demangle.c: New file.
> * testsuite/Makefile.in (really-check): Add check-rust-demangle.
> (check-rust-demangle): New rule.
> * testsuite/rust-demangle-expected: New file.
Are you completely confident that Rust mangling will never change to
start requiring more space in the demangled string? If that could
ever happen, you have chosen an unfortunate API.
Has David Tolnay signed the FSF copyright agreement? I don't see him
on the list.
Other than that, this patch looks OK.
Ian