This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] Add function comments to some prologue/epilogue helpers
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, <nd at arm dot com>
- Date: Tue, 1 Nov 2016 18:26:36 +0000
- Subject: Re: [PATCH][AArch64] Add function comments to some prologue/epilogue helpers
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com;
- Nodisclaimer: True
- References: <57FE0F22.2020209@foss.arm.com> <580DF0E8.4070601@foss.arm.com> <581734CF.2050901@foss.arm.com> <5845102c-bd7d-712f-bdb4-95cb6ae473ca@foss.arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Nov 01, 2016 at 10:49:10AM +0000, Jiong Wang wrote:
> >>>Is this ok for trunk?
> >>>
> >>>Thanks,
> >>>Kyrill
> >>>
> >>>2016-10-12 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
> >>>
> >>> * config/aarch64/aarch64.c (aarch64_register_saved_on_entry): Add
> >>> function comment.
> >>> (aarch64_next_callee_save): Likewise.
> >>> (aarch64_pushwb_single_reg): Likewise.
> >>> (aarch64_gen_storewb_pair): Likewise.
> >>> (aarch64_push_regs): Likewise.
> >>> (aarch64_gen_loadwb_pair): Likewise.
> >>> (aarch64_pop_regs): Likewise.
> >>> (aarch64_gen_store_pair): Likewise.
> >>> (aarch64_gen_load_pair): Likewise.
> >>> (aarch64_save_callee_saves): Likewise.
> >>> (aarch64_restore_callee_saves): Likewise.
>
> I "contributed" some of these functions without comments...
> The new added comments looks good to me though I can't approve.
>
> Thanks for fixing these.
Thanks Jiong, I appreciate you taking the time to look.
This is OK based on Jiong's technical review and after a glance to ensure the
comments made sense to me.
Thanks,
James