This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH], Optimize (double)vec_extract(n) on PowerPC
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 31 Oct 2016 18:04:47 -0500
- Subject: Re: [PATCH], Optimize (double)vec_extract(n) on PowerPC
- Authentication-results: sourceware.org; auth=none
- References: <20161031212556.GA9310@ibm-tiger.the-meissners.org>
On Mon, Oct 31, 2016 at 05:25:56PM -0400, Michael Meissner wrote:
> +(define_insn "vsx_xvcvsxwdp_df"
> + [(set (match_operand:DF 0 "vsx_register_operand" "=ws")
> + (unspec:DF [(match_operand:V4SI 1 "vsx_register_operand" "wa")]
> + UNSPEC_VSX_CVSXWDP))]
> + "VECTOR_UNIT_VSX_P (V2DFmode)"
> + "xvcvsxwdp %x0,%x1"
> + [(set_attr "type" "vecdouble")])
I think the condition here is a pasto? It probably works, but it isn't
exactly clear what it means here.
> +;; Opimize <type> f = (<type>) vec_extract (vi, <n>)
Typo (optimize).
> +;; where <type> is a hardware supported binary floating point type
> +;; that is not double
Full stop.
Looks fine otherwise. Please apply with those things taking care of.
Thanks,
Segher