This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR78056: Fix build failure on Power7
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Kelvin Nilsen <kdnilsen at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Wed, 26 Oct 2016 08:29:54 -0500
- Subject: Re: [PATCH] PR78056: Fix build failure on Power7
- Authentication-results: sourceware.org; auth=none
- References: <dc1e48aa9057a0b8d414aae760b42cdb@linux.vnet.ibm.com>
Hi Kelvin,
On Wed, Oct 26, 2016 at 02:41:43PM +0200, Segher Boessenkool wrote:
> PR target/78056
> * config/rs6000/rs6000.c (spe_init_builtins): Modify loops to not
> define builtin functions from the bdesc_spe_predicates or
> bdesc_spe_evsel arrays if the builtin mask is not compatible with
> the current compiler configuration.
> (paired_init_builtins): Modify loop to not define define builtin
> functions from the bdesc_paried_preds array if the builtin mask is
> not compatible with the current compiler configuration.
Why do you change the SPE and PS builtins init as well? Were they buggy
in the same way, we just never noticed?
> (altivec_init_builtins): Modify loops to not define the
> __builtin_altivec_stxvl function nor the builtin functions from
> the bdesc_dst or bdesc_altivec_preds, bdesc_abs
I think you lost the last line(s) here?
So, you do not want to create the builtins that we expand to machine insns
that are not supported with the -mcpu= (or other flags) in use. What does
the ABI have to say about this?
Segher