This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Mike Stump <mikestump at comcast dot net>, Martin Sebor <msebor at gmail dot com>
Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Jakub Jelinek <jakub at redhat dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 24 Oct 2016 13:01:14 +0200
Subject: Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
Authentication-results: sourceware.org; auth=none
References: <57FCC339.3040902@foss.arm.com> <20161011105633.GT7282@tucnak.redhat.com> <fa5ae0a4-2764-97b2-9f0c-ca1f6b7e105e@redhat.com> <26030f42-af5c-f9d5-1e26-a0f222b97220@redhat.com> <57FD03A7.5030409@foss.arm.com> <f6e4a0fb-a541-55de-1417-771fb9e288c1@gmail.com> <20161011191953.GA7282@tucnak.redhat.com> <57FE08FF.5020302@foss.arm.com> <57FE0DF4.2020603@foss.arm.com> <57FE2FDC.4020206@foss.arm.com> <7ea488ea-a604-5314-32cf-870e7bee7a01@gmail.com> <57FF41AB.4020301@foss.arm.com> <580A1EAA.8050605@foss.arm.com> <b660ad5e-d408-6d39-99d7-7126d5710155@gmail.com> <C64F40BD-26A3-4B05-8C65-6860B12923BD@comcast.net>

On 10/21/2016 10:59 PM, Mike Stump wrote:

On Oct 21, 2016, at 12:47 PM, Martin Sebor <msebor@gmail.com> wrote:


The latest patch works as expected for me, both with an operand
and with stdin.  But since I'm not empowered to approve it one
of the others reviewers will need to give it their blessing.


Seems fine from a test suite perspective, but not my file.

Well, if it just takes someone to say "OK", I guess I'll do that. Idon't awk however, so I'm relying on other people's judgement on that.


Quite possibly the script should have testcases.


Bernd

Follow-Ups:
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov

References:
- [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Jakub Jelinek
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Bernd Schmidt
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Jeff Law
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Martin Sebor
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Jakub Jelinek
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Martin Sebor
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Kyrill Tkachov
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Martin Sebor
- Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives
  - From: Mike Stump

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]