This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: new pass to warn on questionable uses of alloca() and VLAs


On 10/19/2016 03:08 AM, Eric Botcazou wrote:
My apologies for the delay.  I have finally committed this patch.
Before doing so, I merged with trunk and re-tested (x86-64 Linux) just
in case.  There were no regressions.

Can you rename the testcases?  Git doesn't like the names:

*** These collisions happen when the name of two or more files
*** differ in casing only (Eg: "hello.txt" and "Hello.txt").
*** Please re-do your commit, chosing names that do not collide.
***
***     Commit: 09b6f37fdbc6b8955a13bce336f4679bb0da78d7
***     Subject: Manual merge of 'origin/fsf-gcc-head-branch' into gcc-head
(no-tn-check).
***
*** The matching files are:
***
***     gcc/testsuite/gcc.dg/Wvla-2.c
***     gcc/testsuite/gcc.dg/wvla-2.c
***
***     gcc/testsuite/gcc.dg/Wvla-1.c
***     gcc/testsuite/gcc.dg/wvla-1.c
***
***     gcc/testsuite/gcc.dg/Wvla-3.c
***     gcc/testsuite/gcc.dg/wvla-3.c)


It seems to me that there is a precedence for -W type tests to start with a capital letter, as opposed to a lowercase letter:

$ cd gcc.dg
$ ls W[a-z]* |wc
    280     280    5816

Do you think it would perhaps be reasonable to rename all of them to uppercase? You could take -Wvla-[1-7].c and I can take the subsequent ones?

Aldy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]