This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgo patch committed: copy rdebug code from Go 1.7
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Ian Lance Taylor <iant at golang dot org>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
- Date: Wed, 19 Oct 2016 13:30:44 +0200
- Subject: Re: libgo patch committed: copy rdebug code from Go 1.7
- Authentication-results: sourceware.org; auth=none
- References: <CAOyqgcXdAiGEhSNdO1Sv_-50BzM7Z+e1bp+R-X5+z_=kAgjGkw@mail.gmail.com>
On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor <iant@golang.org> wrote:
> This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo.
>
> While we're at it, this updates the runtime/debug package, and starts
> running its testsuite by default. I'm not sure why runtime/debug was
> not previously updated to 1.7. Doing that led me to fix some minor
> aspects of runtime.Stack and the C function runtime/debug.readGCStats.
>
> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
> to mainline.
Not sure which of the merges broke it but I get
...
rc/svn/trunk2/libgo/go/runtime/time.go
/space/rguenther/src/svn/trunk2/libgo/go/runtime/trace.go
/space/rguenther/src/svn/trunk2/libgo/go/runtime/traceback_gccgo.go
/space/rguenther/src/svn/trunk2/libgo/go/runtime/type.go
/space/rguenther/src/svn/trunk2/libgo/go/runtime/typekind.go
/space/rguenther/src/svn/trunk2/libgo/go/runtime/write_err.go
runtime_sysinfo.go -fPIC -o .libs/runtime-go.o
/space/rguenther/src/svn/trunk2/libgo/go/runtime/netpoll_epoll.go:52:49:
error:integer constant overflow
ev.events = _EPOLLIN | _EPOLLOUT | _EPOLLRDHUP | _EPOLLET
^
make[4]: *** [runtime-go.lo] Error 1
now and bootstrap is broken for me. This is on x86_64-linux, SLES 11
SP4 which uses glibc 2.11.3.
There is a missing space after 'error:' as well.
Please fix.
Thanks,
Richard.
> Ian