This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] rs6000: Fix shrink-wrap-separate for AIX
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 15 Oct 2016 07:55:47 -0400
- Subject: Re: [PATCH] rs6000: Fix shrink-wrap-separate for AIX
- Authentication-results: sourceware.org; auth=none
- References: <b677554b8660e0c112f9debb9588b1567219c2c4.1476498617.git.segher@kernel.crashing.org>
On Fri, Oct 14, 2016 at 11:00 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> All out-of-line register save routines need LR, so we cannot wrap the
> LR component if there are out-of-line saves. This didn't show up for
> testing on Linux because none of the tests there use out-of-line FPR
> saves without also using out-of-line GPR saves, which we did handle.
>
> This patch fixes it, and also cleans up code a little.
>
> Is this okay for trunk?
>
>
> Segher
>
>
> 2016-10-15 Segher Boessenkool <segher@kernel.crashing.org>
>
> * config/rs6000/rs6000.c (rs6000_get_separate_components): Do not
> make LR a separately shrink-wrapped component if savres_strategy
> contains any of {SAVE,REST}_INLINE_{GPRS,FPRS,VRS}. Do not wrap
> GPRs if {SAVE,REST}_INLINE_GPRS. Do not disallow all wrapping
> when {SAVE,REST}_INLINE_GPRS.
This is okay.
Maybe rs6000 always should prefer inline save-restore when SWS is
enabled, except for optimize_size?
Thanks, David