This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, GCC] Move MEMMODEL_* and enum memmodel from coretypes.h to memmodel.h
On Thu, 13 Oct 2016, Thomas Preudhomme wrote:
> On 12/10/16 21:00, Joseph Myers wrote:
> > On Wed, 12 Oct 2016, Thomas Preudhomme wrote:
> >
> > > This patch is a follow up of [1] which aims to have all memory model
> > > related
> > > declarations in memmodel.h. To achieve that, this patch moves memory model
> > > related declaration from coretypes.h into memmodel.h. Note that since
> > > memmodel.h is now included from libgcc it needs to have a runtime library
> > > exception.
> >
> > I think libgcc should be using the __ATOMIC_* predefines instead of the
> > MEMMODEL_* host-side constants. (In general, we should be moving away
> > from including host-side headers in target-side code.)
> >
>
> That's a better solution indeed. I've updated the patch, and did another
> x86_64 bootstrap and built a tilepro-linux-gnu cross-compiler for good
> measure. It's all good.
>
> Ok for trunk?
Ok.
Richard.