This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)
- From: Marek Polacek <polacek at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 13 Oct 2016 11:52:53 +0200
- Subject: Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)
- Authentication-results: sourceware.org; auth=none
- References: <20161012232522.GY7282@tucnak.redhat.com>
On Thu, Oct 13, 2016 at 01:25:22AM +0200, Jakub Jelinek wrote:
> Hi!
>
> Seems 2 functions in varasm.c just use TREE_PUBLIC on LABEL_DECLs together
> with other kinds of decls, but as TREE_PUBLIC on LABEL_DECLs means now
> something different, it breaks badly.
> While I could change those 2 functions in varasm.c, I'm afraid other
> functions might be doing something similar, so I think TREE_PRIVATE which is
> used far less often is a better choice for the flag bit here.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
Given this is a part of fallthru machinery: LGTM, but can't really approve.
Marek