This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] [ARC] Fix mul32x16 patterns.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gnu at amylaar dot uk, Francois dot Bedard at synopsys dot com
- Date: Wed, 12 Oct 2016 15:05:10 +0100
- Subject: Re: [PATCH 2/2] [ARC] Fix mul32x16 patterns.
- Authentication-results: sourceware.org; auth=none
- References: <1467282252-6108-1-git-send-email-claziss@synopsys.com> <1467282252-6108-2-git-send-email-claziss@synopsys.com>
* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2016-06-30 12:24:12 +0200]:
> The mululw instructions are wrongly used in the patterns, fix them.
>
> Okt to apply?
> Claudiu
>
> gcc/
> 2016-06-28 Claudiu Zissulescu <claziss@synopsys.com>
>
> * config/arc/arc.md (umul_600): Change.
> (umul64_600): Likewise.
Looks fine, though maybe you could be a little more descriptive with
the ChangeLog entry.
Thanks,
Andrew
> ---
> gcc/config/arc/arc.md | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
> index 2464a19..41b8eed 100644
> --- a/gcc/config/arc/arc.md
> +++ b/gcc/config/arc/arc.md
> @@ -1937,13 +1937,11 @@
> (const_int 0))))
> (clobber (match_operand:SI 3 "acc1_operand" ""))]
> "TARGET_MULMAC_32BY16_SET"
> - "@mululw 0, %0, %1
> - mululw 0, %0, %1
> - mululw%? 0, %1, %0"
> + "mululw 0, %0, %1"
> [(set_attr "length" "4,4,8")
> - (set_attr "type" "mulmac_600, mulmac_600, mulmac_600")
> - (set_attr "predicable" "no, no, yes")
> - (set_attr "cond" "nocond, canuse_limm, canuse")])
> + (set_attr "type" "mulmac_600")
> + (set_attr "predicable" "no")
> + (set_attr "cond" "nocond")])
>
> (define_insn "mac_600"
> [(set (match_operand:SI 2 "acc2_operand" "")
> @@ -2372,13 +2370,11 @@
> (const_int 0))))
> ]
> "TARGET_MULMAC_32BY16_SET"
> - "@mululw 0, %0, %1
> - mululw 0, %0, %1
> - mululw%? 0, %1, %0"
> + "mululw 0, %0, %1"
> [(set_attr "length" "4,4,8")
> (set_attr "type" "mulmac_600")
> - (set_attr "predicable" "no,no,yes")
> - (set_attr "cond" "nocond, canuse_limm, canuse")])
> + (set_attr "predicable" "no")
> + (set_attr "cond" "nocond")])
>
>
> (define_insn "umac64_600"
> --
> 1.9.1
>