This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Questionable code in gcov-io.c

From: Nathan Sidwell <nathan at acm dot org>
To: Marek Polacek <polacek at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
Date: Wed, 12 Oct 2016 09:45:32 -0400
Subject: Re: Questionable code in gcov-io.c
Authentication-results: sourceware.org; auth=none
References: <20161012121001.GA27295@redhat.com> <5d4f3cdb-4698-f323-fe38-e2a80421034f@acm.org> <20161012134323.GC27295@redhat.com>

On 10/12/16 09:43, Marek Polacek wrote:

ITYM lines 197 -> 203.  I.e. remove the entire if that;s inside the 'mode ==
0' branch and make line 203 unconditional.


Yes, sorry for sloppy wording.  I'm testing a patch.


heh, so am I :)

nathan

References:
- Questionable code in gcov-io.c
  - From: Marek Polacek
- Re: Questionable code in gcov-io.c
  - From: Nathan Sidwell
- Re: Questionable code in gcov-io.c
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]