This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM 5/7] Add support for MOVT/MOVW to ARMv8-M Baseline
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Date: Tue, 11 Oct 2016 14:28:08 +0100
- Subject: Re: [PATCH, ARM 5/7] Add support for MOVT/MOVW to ARMv8-M Baseline
- Authentication-results: sourceware.org; auth=none
- References: <003701d138a2$0d9e9890$28dbc9b0$@foss.arm.com> <57861195.8040308@foss.arm.com> <CAKdteOYL-MigK2HF8PpYabS6b8ZXA7mzLBJw=BeS_EBczqd2Fw@mail.gmail.com> <2564123.FxTpzdQTnq@e108577-lin> <CAKdteOaqO64oNb+9nSVF=7si3yo77UZxmndfJhjTuSaA4wqVMg@mail.gmail.com>
On 10/10/16 13:35, Christophe Lyon wrote:
Hi Thomas,
Hi Christophe,
On 13 July 2016 at 17:34, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
On Wednesday 13 July 2016 17:14:52 Christophe Lyon wrote:
Hi Thomas,
Hi Christophe,
I'm seeing:
gcc.target/arm/pr42574.c: syntax error in target selector
"arm_thumb1_ok && { ! arm_thumb1_movt_ok }" for " dg-do 1 compile {
arm_thumb1_ok && { ! arm_thumb1_movt_ok } } "
Oops. I remember the trial and error to find the right amount of curly braces
yet I can indeed reproduce the error now. The target keyword is missing. I'll
submit a patch asap.
Best regards,
Thomas
I've noticed that the new test
gcc.target/arm/movdi_movw.c scan-assembler-times movw\tr0, #61680 1
fails on armeb-none-linux-gnueabihf
--with-mode=thumb --with-cpu=cortex-a9 --with-fpu=neon-fp16
It seems DImode values are stored differently in register depending on the
endianness. For little endian the low bits would be in the lowest register, but
it's reverse in big endian. I'll adapt the test accordingly.
the other new tests pass, and using --with=mode=arm makes all three
of them unsupported.
Right, there is no reason to forbid ARM state indeed. I'll fix that too.
Sorry I missed it when I reported the other error.
No worry.
Can you have a look?
Absolutely.
Cheers,
Thomas