This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math
- From: Fritz Reese <fritzoreese at gmail dot com>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: Jerry DeLisle <jvdelisle at charter dot net>, fortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Oct 2016 07:26:35 -0400
- Subject: Re: PING! Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math
- Authentication-results: sourceware.org; auth=none
- References: <CAE4aFA=CHwyvTuxAz_ZYB_qNxCKn_PuirobFJy6Xn-+sUd4vyA@mail.gmail.com> <7b44bb75-0d58-b51e-9248-c717cd7383ec@charter.net> <20161010195631.GA8204@troutmask.apl.washington.edu>
On Mon, Oct 10, 2016 at 3:56 PM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
...
> There are a few small clean-up that can be
> done. For example,
>
> +static gfc_expr *
> +get_radians (gfc_expr *deg)
> +{
> + mpfr_t tmp;
...
> the tmp variable is unneeded in the above. Converting the double
> precision 180.0 to mpfr_t and then dividing is probably slower
> than just dividing by 180.
>
> + /* Set factor = pi / 180. */
> + factor = gfc_get_constant_expr (deg->ts.type, deg->ts.kind, °->where);
> + mpfr_const_pi (factor->value.real, GFC_RND_MODE);
> + mpfr_div_ui (factor->value.real, factor->value.real, 180, GFC_RND_MODE);
>
...
Good catch, fixed and committed r240989. Many thanks to you and Jerry.
---
Fritz Reese