Re: [PATCH 08/16] (partially-approved): Introduce selftest::locate_file

[Bernd Schmidt <bschmidt at redhat dot com>]

On 10/05/2016 06:15 PM, David Malcolm wrote:
>  selftest: s-selftest
>  s-selftest: $(GCC_PASSES) cc1$(exeext) stmp-int-hdrs
> -	$(GCC_FOR_TARGET) -xc -S -c /dev/null -fself-test
> +	$(GCC_FOR_TARGET) -xc -S -c /dev/null -fself-test=$(srcdir)
>  	$(STAMP) $@

I suspect the Makefile parts will need updating once Thomas commits his 
change.

Also,

> +  return concat (path_to_src_gcc, "/testsuite/selftests/", name, NULL);

why hardcode directory names here? I think this should just be passed as 
a full pathname so only the Makefiles have knowledge of source directory 
structure.


Bernd