This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make CHECKING_P a boolean flag again

From: Jeff Law <law at redhat dot com>
To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Jakub Jelinek <jakub at redhat dot com>
Date: Fri, 30 Sep 2016 11:14:19 -0600
Subject: Re: [PATCH] Make CHECKING_P a boolean flag again
Authentication-results: sourceware.org; auth=none
References: <AM4PR0701MB2162A07026F686DBECFD7BE6E4CA0@AM4PR0701MB2162.eurprd07.prod.outlook.com>

On 09/25/2016 03:13 AM, Bernd Edlinger wrote:

Hi!


Currently CHECKING_P is not a boolean flag but a ternary option.
However the _P in the name implies it is a boolean.

That should be cleaned up again IMHO.


So this patch splits CHECKING_P into CHECKING_P and a new flag
ENABLE_EXTRA_CHECKING.  All uses of CHECKING_P are actually of
the form "if (CHECKING_P)" so there is no problem there, only the
flag_checking is tested at one place for > 1,  thus we have to
make sure that the default initial value of flag_checking is
0, 1 or 2, dependent on CHECKING_P and ENABLE_EXTRA_CHECKING.


Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Is it OK for trunk?


Thanks
Bernd.


changelog-checking-p.txt


2016-09-25  Bernd Edlinger  <bernd.edlinger@hotmail.de>

	* configure.ac: Split CHECKING_P into CHECKING_P and
	ENABLE_EXTRA_CHECKING.
	* configure: Regenerated.
	* config.in: Adjust commment of CHECKING_P.  Add ENABLE_EXTRA_CHECKING.
	* common.opt (flag_checking): Use CHECKING_P and ENABLE_EXTRA_CHECKING.

OK.

jeff

References:
- [PATCH] Make CHECKING_P a boolean flag again
  - From: Bernd Edlinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]