This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Marek Polacek <polacek at redhat dot com>, Jason Merrill <jason at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Fri, 30 Sep 2016 11:45:45 +0200
- Subject: Re: [PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label
- Authentication-results: sourceware.org; auth=none
- References: <20160929201633.GV7282@tucnak.redhat.com> <20160930092627.GZ3223@redhat.com> <20160930093143.GZ7282@tucnak.redhat.com> <2006587.X6q2xGV3ka@polaris>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Sep 30, 2016 at 11:42:12AM +0200, Eric Botcazou wrote:
> > Clearly people are extremely creative with these comments, maybe it would be
> > better to just remove the new additions from the patch I've posted (drop
> > the else/intentational/intentationally/... around/!!! around etc., to force
> > people to standardize on something), and just apply the fixes and support
> > for comments in between.
>
> Maybe just match "fall" and "through/thru/etc" positively and "not/n't/etc"
> negatively on the same line.
See Tom Tromey's explanation why accepting too much is bad (at least unless
we want multiple levels).
Jakub