This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gomp4] Fix tile parsing


On 09/27/16 14:07, Jakub Jelinek wrote:

+	case OMP_CLAUSE_TILE:
+	  /* These clauses really need a positive integral constant
+	     expression, but we don't have a predicate for that
+	     (yet).  */
+	  needs_ice = true;
+	  /* FALLTHRU */

But why do you need this (at least for OMP_CLAUSE_COLLAPSE)?
The OMP_CLAUSE_COLLAPSE (and OMP_CLAUSE_ORDERED if not NULL) argument
is required to be INTEGER_CST already during parsing, it can't be even
template argument etc. (because we need that number already during parsing
to find out how many nested loops to parse specially).
So I don't see how would the last argument to tsubst_expr make any
difference there.

Oh, I'd not realized it couldn't be a template argument. (the same is not true of tile parameters).

nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]