This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Implement -Wimplicit-fallthrough (version 9)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Marek Polacek <polacek at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Arnaud Charlet <charlet at adacore dot com>
- Date: Tue, 27 Sep 2016 10:17:44 +0200
- Subject: Re: Implement -Wimplicit-fallthrough (version 9)
- Authentication-results: sourceware.org; auth=none
- References: <20160920153343.GF19950@redhat.com> <yddintiyebz.fsf@CeBiTec.Uni-Bielefeld.DE> <CADzB+2kyUObMR-1o45S=gVqYNGi3VTFk=27rftGW_1Q3PYTkeg@mail.gmail.com> <3916173.q8VWCuMk9Z@polaris>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Sep 27, 2016 at 08:49:00AM +0200, Eric Botcazou wrote:
> > It seems unfortunate that the warning doesn't accept /* ... fall
> > through ... */ as a fallthrough comment.
>
> Seconded. The warning should take into account existing practices instead of
> forcing the user to make completely bogus changes to the code (and Ada should
> have been tested before the patch was approved).
The intent has been that we catch the most common forms, but still require it not
to be complete free form. Because, as experience shows, people are
extremely creative in these comments, and it is not very good idea to
support everything. For ... fall through ... , what is the purpose of those
...s?
Jakub