This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [accaf, fortran, 4/4] Allocatable components support in derived typed coarrays


Hi Dominique,

Yes of course. It makes sense to have the param a 4byte entity on 32 bit systems. Please commit. I am on a mobile only currently and can't do so before tomorrow afternoon.

Thanks for that correction.

Regards,
Andre

Am 24. September 2016 13:58:45 MESZ, schrieb "Dominique d'Humières" <dominiq@lps.ens.fr>:
>Hi Andre,
>
>It seems that the committed test gfortran.dg/coarray_lib_comm_1.f90 is
>not right. I have to apply the patch
>
>---
>../_clean/gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90	2016-09-23
>12:45:56.000000000 +0200
>+++ gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90	2016-09-24
>12:15:02.000000000 +0200
>@@ -40,7 +40,7 @@ end
> 
>! { dg-final { scan-tree-dump-times "_gfortran_caf_sendget
>\\\(caf_token.0, \\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data
>- \\\(integer\\\(kind=\[48\]\\\)\\\) a, _gfortran_caf_this_image
>\\\(0\\\), &parm.\[0-9\]+, 0B, caf_token.0,
>\\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=\[48\]\\\)\\\) a, 1, &parm.\[0-9\]+, 0B, 4, 4, 0,
>0B\\\);" 1 "original" } }
>! { dg-final { scan-tree-dump-times "_gfortran_caf_sendget
>\\\(caf_token.0, \\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data
>- \\\(integer\\\(kind=\[48\]\\\)\\\) a, _gfortran_caf_this_image
>\\\(0\\\), &parm.\[0-9\]+, 0B, caf_token.0,
>\\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=\[48\]\\\)\\\) a, 1, &parm.\[0-9\]+, 0B, 4, 4, 1,
>0B\\\);" 1 "original" } }
>-! { dg-final { scan-tree-dump-times "_gfortran_caf_get
>\\\(caf_token.0, \\\(integer\\\(kind=8\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=8\\\)\\\) a, 1, &parm.\[0-9\]+, 0B, &p, 4, 4, 1,
>0B\\\);" 1 "original" } }
>-! { dg-final { scan-tree-dump-times "_gfortran_caf_get
>\\\(caf_token.1, \\\(integer\\\(kind=8\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=8\\\)\\\) b, 1, &parm.\[0-9\]+, 0B, &p, 4, 4, 0,
>0B\\\);" 1 "original" } }
>+! { dg-final { scan-tree-dump-times "_gfortran_caf_get
>\\\(caf_token.0, \\\(integer\\\(kind=[48]\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=8\\\)\\\) a, 1, &parm.\[0-9\]+, 0B, &p, 4, 4, 1,
>0B\\\);" 1 "original" } }
>+! { dg-final { scan-tree-dump-times "_gfortran_caf_get
>\\\(caf_token.1, \\\(integer\\\(kind=[48]\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=8\\\)\\\) b, 1, &parm.\[0-9\]+, 0B, &p, 4, 4, 0,
>0B\\\);" 1 "original" } }
>! { dg-final { scan-tree-dump-times "_gfortran_caf_sendget
>\\\(caf_token.0, \\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data
>- \\\(integer\\\(kind=\[48\]\\\)\\\) a, 1, &parm.\[0-9\]+, 0B,
>caf_token.0, \\\(integer\\\(kind=\[48\]\\\)\\\) parm.\[0-9\]+.data -
>\\\(integer\\\(kind=\[48\]\\\)\\\) a, 1, &parm.\[0-9\]+, 0B, 4, 4, 0,
>0B\\\);" 1 "original" } }
> 
>to make it pass with -m32.
>
>I can do the commit if it helps.
>
>TIA
>
>Dominique

-- 
Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen
Tel.: +49 241 929 10 18 * vehre@gmx.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]