This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix variant::operator= on references
- From: Tim Shen <timshen at google dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Date: Thu, 22 Sep 2016 01:49:34 -0700
- Subject: Re: [Patch] Fix variant::operator= on references
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNn3pK3LhyPSRxVT1gzmmbBuCcjnqOtsP3ZOiXJM=eFcew@mail.gmail.com> <20160922083952.GT17376@redhat.com>
On Thu, Sep 22, 2016 at 1:39 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
> Please qualify std::forward here.
Done. When writing the initial version, I was trying to save as much
qualifications as possible (as long as the semantic doesn't change)
for readability, but that might not be a good idea.
>
> OK for trunk with that change, thanks for the quick fix.
>
>
Committed. Thanks!
--
Regards,
Tim Shen