This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.

From: Mark Wielaard <mjw at redhat dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: Jim Meyering <jim at meyering dot net>, Eric Gallager <egall at gwmail dot gwu dot edu>, Manuel López-Ibáñez <lopezibanez at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <iant at google dot com>, Paolo Bonzini <bonzini at gnu dot org>, Diego Novillo <dnovillo at google dot com>, Le-Chun Wu <lcwu at google dot com>, Joseph Myers <joseph at codesourcery dot com>
Date: Wed, 14 Sep 2016 10:30:57 +0200
Subject: Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
Authentication-results: sourceware.org; auth=none
References: <CAMfHzOszteR0Ky_+7ioFkpu9-K5m8NRozqGJhh0FNGcFDSWPZg@mail.gmail.com> <1473598955-9246-1-git-send-email-mjw@redhat.com> <669d316c-b2a2-b511-8868-783e98783479@gmail.com> <CAMfHzOsTHCw-QkA03T4QcAY8AsVH3HP11UhCMc9eJWWTNT6DSQ@mail.gmail.com> <CA+8g5KHsUqwdUFV8C_w6UnRKyHWArqd-v-=8MTAkq1XRSbVgEg@mail.gmail.com> <CADzB+2no2hSf6XxkX7h9Y3M_3DmpWNyh_HoGt9Of_PkAgE=cew@mail.gmail.com>

On Wed, 2016-09-14 at 00:00 -0400, Jason Merrill wrote:
> I wonder about spelling the options as
> -Wshadow={local,compatible-local} rather than with a dash, but
> otherwise the patch looks fine.

That is a much nicer way to write the option. But if I do that I would
like to keep the old names as aliases because Google already ships a gcc
that accepts -Wshadow-local and -Wshadow-compatible-local and you can
find programs that already probe for those names in their configure
scripts. Can I make the existing names hidden aliases by marking them
Undocumented in the .opt file? Or is that too contrived/ugly?

Thanks,

Mark

Follow-Ups:
- Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Ian Lance Taylor

References:
- Re: [PATCH] Fix -Wshadow warning in libiberty/cp-demangle.c
  - From: Eric Gallager
- [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Mark Wielaard
- Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Manuel López-Ibáñez
- Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Eric Gallager
- Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Jim Meyering
- Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]