This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
To: Jeff Law <law at redhat dot com>, Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Peter Bergner <bergner at vnet dot ibm dot com>
Cc: Andrew Pinski <pinskia at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Vladimir Makarov <vmakarov at redhat dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
Date: Mon, 12 Sep 2016 22:01:56 +0000
Subject: Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=softfail (sender IP is 10.152.0.58) smtp.mailfrom=hotmail.de; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=hotmail.de;
References: <HE1PR0701MB2169D0240E850A1E7C8802C0E4FC0@HE1PR0701MB2169.eurprd07.prod.outlook.com> <e960a349-732b-d6a6-a049-bcb500847dba@vnet.ibm.com> <57D6A451.1030700@foss.arm.com> <AM4PR0701MB21620B0A84C1D7F82A0DC706E4FF0@AM4PR0701MB2162.eurprd07.prod.outlook.com> <ecc1bf51-3637-0f25-74b0-b7fa25efdc3b@redhat.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On 09/12/16 23:45, Jeff Law wrote:
> On 09/12/2016 07:43 AM, Bernd Edlinger wrote:
>> Hi,
>>
>> the attached patch boot-straps and reg-tests cleanly
>> on x86_64-pc-linux-gnu, powerpc and aarch64 targets.
>>
>> Is it OK for trunk?
> Unfortunately, there's no explanation for why the original code was
> wrong.  Yes, I can clearly see you're trying to fix an ICE, but what
> about the code's behaviour was wrong?
>
> jeff
>

Sorry,

everything is just folding, and continuing Peter's cleanup,
except here:

@@ -1840,7 +1829,7 @@ process_alt_operands (int only_alternative)

        op = no_subreg_reg_operand[nop] = *curr_id->operand_loc[nop];
        /* The real hard regno of the operand after the allocation.  */
-      hard_regno[nop] = get_hard_regno (op);
+      hard_regno[nop] = get_hard_regno (op, true);

        operand_reg[nop] = reg = op;
        biggest_mode[nop] = GET_MODE (op);


note the comment above.  This restores the state before Peter's patch
here, but only here, not in the operand matching.



Bernd.

References:
- Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
  - From: Bernd Edlinger
- Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
  - From: Peter Bergner
- Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
  - From: Kyrill Tkachov
- [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
  - From: Bernd Edlinger
- Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]