This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] optabs.c: Update inline documentation
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <gcc-patches at gcc dot gnu dot org>
- Cc: Paolo Bonzini <bonzini at gnu dot org>
- Date: Mon, 12 Sep 2016 15:37:08 +0100
- Subject: [PATCH] optabs.c: Update inline documentation
- Authentication-results: sourceware.org; auth=none
Hi,
I've noticed commit 147425 ("cond-optab merge target-independent bits"),
<https://gcc.gnu.org/ml/gcc-patches/2009-04/msg01030.html>, changed the
semantics of `prepare_cmp_insn' function arguments, however did not fully
accordingly update its documentation comment. Here's the missing update.
gcc/
* optabs.c (prepare_cmp_insn): Update documentation comment.
OK to apply?
Maciej
gcc-optabs-prepare-cmp-insn-doc.diff
Index: gcc/gcc/optabs.c
===================================================================
--- gcc.orig/gcc/optabs.c 2016-08-15 17:24:21.124480231 +0100
+++ gcc/gcc/optabs.c 2016-08-15 17:42:29.370598925 +0100
@@ -3716,13 +3716,17 @@ can_compare_p (enum rtx_code code, machi
}
/* This function is called when we are going to emit a compare instruction that
- compares the values found in *PX and *PY, using the rtl operator COMPARISON.
+ compares the values found in X and Y, using the rtl operator COMPARISON.
- *PMODE is the mode of the inputs (in case they are const_int).
- *PUNSIGNEDP nonzero says that the operands are unsigned;
+ If they have mode BLKmode, then SIZE specifies the size of both operands.
+
+ UNSIGNEDP nonzero says that the operands are unsigned;
this matters if they need to be widened (as given by METHODS).
- If they have mode BLKmode, then SIZE specifies the size of both operands.
+ *PTEST is where the resulting comparison RTX is returned or NULL_RTX
+ if we failed to produce one.
+
+ *PMODE is the mode of the inputs (in case they are const_int).
This function performs all the setup necessary so that the caller only has
to emit a single comparison insn. This setup can involve doing a BLKmode