This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386] Spellcheck hints for the i386 backend option handling (PR middle-end/77475)

On Mon, Sep 05, 2016 at 07:54:15PM -0400, David Malcolm wrote:
> The calls into spellcheck.h are minimal and look reasonable (I can't
> really comment on the x86 aspects).  So I have little to add beyond the
> cleanups that Manu already observed.
> 
> One thing: shouldn't this have testcases that give test coverage for
> emitting hints for -march and -mtune? Something like
>   gcc/testsuite/gcc.dg/spellcheck-options-11.c
> (though obviously the new ones would be target-specific).

I guess I could add one, but would prefer not to list all the CPUs, just
perhaps few first ones, because otherwise whenever a new CPU is added we'll
need to adjust the testcase.

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]